-
Notifications
You must be signed in to change notification settings - Fork 92
feat: add HoMM factions to the lab wiki #6439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
faction data has no return
| h1 = factionPropsH1, | ||
| h2 = factionPropsH2, | ||
| h3 = factionPropsH3, | ||
| h4 = factionPropsH4, | ||
| h5 = factionPropsH5, | ||
| hoe = factionPropsHOE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the keys have to match the game keys used in Module:Info
i doubt we will use h1-h5 there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the common abbreviations used within the community. For a separate homm alpha wiki, these would be by far the most sensible abbreviations. Are you worried, that there might be collision with other games? I think, it's rather safe since most other games are single-game wikis and everything in labs is ideally only temporary.
homm may be a reasonable abbreviation for the 6 games added as of yet, but h6 and h7 were released as "might & magic: heroes", i.e. mm:h. And writing something like hommoe seems unnecessarily verbose and does not really make things easier. Yet, I am open to other suggestions or arguments :)
|
@hjpalpha sorry for the review request, was not intended and is not yet neccessary. |

Summary
This is for now a draft PR for adding factions to the Heroes of Might and Magic lab wiki.
TODO: