Skip to content

Conversation

@Libavi
Copy link
Contributor

@Libavi Libavi commented Aug 22, 2025

Summary

This is for now a draft PR for adding factions to the Heroes of Might and Magic lab wiki.

TODO:

  • The faction images should be uploaded to liquipedia commons before this PR is accepted.
  • Other files have to be changed/added, e.g. in the lab wiki: MatchSummary.lua and MatchGroup/Input/Custom.lua

@Libavi Libavi marked this pull request as draft August 22, 2025 21:11
@Libavi Libavi changed the title Homm factions feat: Add HoMM factions to the lab wiki Aug 22, 2025
@Libavi Libavi changed the title feat: Add HoMM factions to the lab wiki feat: add HoMM factions to the lab wiki Aug 22, 2025
@hjpalpha
Copy link
Collaborator

IMG_5274

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faction data has no return

Comment on lines 367 to 372
h1 = factionPropsH1,
h2 = factionPropsH2,
h3 = factionPropsH3,
h4 = factionPropsH4,
h5 = factionPropsH5,
hoe = factionPropsHOE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the keys have to match the game keys used in Module:Info
i doubt we will use h1-h5 there

Copy link
Contributor Author

@Libavi Libavi Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the common abbreviations used within the community. For a separate homm alpha wiki, these would be by far the most sensible abbreviations. Are you worried, that there might be collision with other games? I think, it's rather safe since most other games are single-game wikis and everything in labs is ideally only temporary.
homm may be a reasonable abbreviation for the 6 games added as of yet, but h6 and h7 were released as "might & magic: heroes", i.e. mm:h. And writing something like hommoe seems unnecessarily verbose and does not really make things easier. Yet, I am open to other suggestions or arguments :)

@Libavi Libavi requested a review from hjpalpha August 26, 2025 11:14
@Libavi
Copy link
Contributor Author

Libavi commented Aug 26, 2025

@hjpalpha sorry for the review request, was not intended and is not yet neccessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants