-
Notifications
You must be signed in to change notification settings - Fork 92
feat: add replay operator as staff role #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
added replay operator as staff role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise okay
personally indifferent about it getting added or not
|
fyi, the employee that merges lua PRs is curr on vacation so it will take a bit until this gets reviewed by him |
Co-authored-by: SyntacticSalt <[email protected]>
|
What's a reply operator? |
If you watch a broadcast you sometimes have (instant) replays of big/important plays as soon as they happened, or at the end of a match you have a hightlight reel of all key plays of the game. The replay operator/replay observer is usually a dedicated role additional to the normal observer doing this. Its a rather niche role compared to your normal Producer/Observer/Caster but quiet demanding |
|
Maybe put it as a Production Staff instead, see eg. producer |
| ['organizer'] = {category = 'Tournament Organizer', display = 'Tournament Organizer'}, | ||
| ['staff'] = {category = 'Staff', display = 'Staff'}, | ||
| ['referee'] = {category = 'Referees', display = 'Referee'}, | ||
| ['replay operator'] = {category = 'Replay Operators', display = 'Replay Operator'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['replay operator'] = {category = 'Production Staff', display = 'Replay Operator'},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you click this icon when adding a comment
![]()
you can add a proper suggestions that can be directly applied to the code later, like this:
| ['replay operator'] = {category = 'Replay Operators', display = 'Replay Operator'}, | |
| ['replay operator'] = {category = 'Production Staff', display = 'Replay Operator'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also like it to be moved up to tge prod staff, iirc the list is sorted on category
added replay operator as staff role
Summary
I've added Replay Operator as a role to StaffRoles as many tournaments have Replay Operators that don't have any other role like observer etc.
How did you test this change?
I've pasted the text line above and changed names to replay operator