Skip to content

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Sep 26, 2025

Summary

Inspired from #6580

This PR adds overall statistics tab for leagueoflegends matchpage.

How did you test this change?

dev: leagueoflegends:Match:ID User ElectricalBoy zqx7pe0nDj R01-M001

@ElectricalBoy ElectricalBoy marked this pull request as ready for review September 26, 2025 01:57
@ElectricalBoy ElectricalBoy added the g: leagueoflegends League of Legends label Sep 26, 2025
@ElectricalBoy ElectricalBoy force-pushed the matchpage-overall-stats-tab branch from 8ffec28 to 66ff4ed Compare October 4, 2025 00:35
@Rathoz
Copy link
Collaborator

Rathoz commented Oct 6, 2025

Could you do similiar to Valorant one? ie move the calculations to MGI

@ElectricalBoy ElectricalBoy force-pushed the matchpage-overall-stats-tab branch from 6969828 to e7d0c48 Compare October 6, 2025 08:07
@ElectricalBoy ElectricalBoy requested a review from hjpalpha October 6, 2025 13:03
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable on mobile

@ElectricalBoy ElectricalBoy requested a review from Rathoz October 7, 2025 12:18
@ElectricalBoy ElectricalBoy requested a review from hjpalpha October 7, 2025 12:32
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable on phone

@Rathoz Rathoz merged commit f608a99 into main Oct 13, 2025
6 checks passed
@Rathoz Rathoz deleted the matchpage-overall-stats-tab branch October 13, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants