-
Notifications
You must be signed in to change notification settings - Fork 92
feat(match2): overall stats tab for leagueoflegends matchpage #6598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Sep 26, 2025
hjpalpha
approved these changes
Sep 26, 2025
Rathoz
reviewed
Sep 29, 2025
8ffec28 to
66ff4ed
Compare
|
Could you do similiar to Valorant one? ie move the calculations to MGI |
Co-authored-by: hjpalpha <[email protected]>
6969828 to
e7d0c48
Compare
hjpalpha
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable on mobile
Rathoz
reviewed
Oct 6, 2025
hjpalpha
approved these changes
Oct 7, 2025
Rathoz
reviewed
Oct 7, 2025
Rathoz
reviewed
Oct 7, 2025
Rathoz
reviewed
Oct 7, 2025
hjpalpha
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable on phone
Rathoz
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inspired from #6580
This PR adds overall statistics tab for leagueoflegends matchpage.
How did you test this change?
dev: leagueoflegends:Match:ID User ElectricalBoy zqx7pe0nDj R01-M001