fix(standings): upcoming and ongoing matches not filtered by swiss standings table #6618
Conversation
| local opponentRoundData = standingsOpponentData.rounds[roundNumber] | ||
| opponentRoundData.specialstatus = '' | ||
| opponentRoundData.match = match2 | ||
| if (not match2.finished) and (#match2.opponents <= 2) then |
There was a problem hiding this comment.
why the #opp <=2 condition?
don't we also want to not count unfinished matches for ffa standings?
There was a problem hiding this comment.
don't we also want to not count unfinished matches for ffa standings?
it would make sense to let br/ffa point standings to be updated for every map finish instead of match finish, wouldn't it?
(disclaimer: I haven't read through ffa standings impl)
There was a problem hiding this comment.
for normal standings it would also make sense to update based on games in quite a few cases
but that imo is something to solve when adding game support
| end | ||
| opponentRoundData.specialstatus = '' | ||
| opponentRoundData.match = match2 | ||
| local matchResult = match2.winner == 0 and 'd' or opponent.placement == 1 and 'w' or 'l' |
There was a problem hiding this comment.
Isn't the real place to do the fix here?
There was a problem hiding this comment.
if match is not finished then calculating points is somewhat pointless too in swiss
see 5ece1dd
Summary
fixes #6616
How did you test this change?
dev