feat: Add transparent theme color for POIDraft #6631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidely
approved these changes
Oct 6, 2025
Rathoz
changed the title
Rathoz
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I got some suggestions and wanna slowly apply them. First of the suggestion was to have POI Label to have transparent color
If merged need to replace placement-1 and bg-dq for these custom css.
Personally not sure if there are any rules when to use RGBA/HEX/etc... I wouldn't be suprise if my implementation is not even good. CSS is a big unknown for me.
Related templates and modules:
I know that modules are not likely up to standard. I shared them just so you have idea where this css gonna be used
https://liquipedia.net/apexlegends/Module:Widget/POIDraft/POIMap
https://liquipedia.net/apexlegends/Module:Widget/POIDraft/POIMap/Data
https://liquipedia.net/apexlegends/Module:Widget/POIDraft/Table
https://liquipedia.net/apexlegends/Module:Widget/POIDraft/POILabel
Page where such POIDraft template is used:
https://liquipedia.net/apexlegends/Apex_Legends_Global_Series/2025/Split_2/Pro_League/EMEA/POI_Drafts
How did you test this change?
dev tools