-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSockets tutorial #256
WebSockets tutorial #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I really like it.
Co-Authored-By: Moritz <[email protected]>
Co-Authored-By: Moritz <[email protected]>
Co-Authored-By: Moritz <[email protected]>
Co-Authored-By: Moritz <[email protected]>
Co-Authored-By: Moritz <[email protected]>
@mohe2015 Thanks for the review! |
Spiffy! However, issue #255 mentions not using |
@pnathan That's correct, see my comment at the top of this PR. I had initially wanted to use Clack and websocket-driver, using Woo as the underlying web server, but had some issues. I later discovered that the issues had to do with Woo and were not directly related to Clack and websocket-driver. And so, because the community seemed to prefer the Clack ecosystem, and because I had wanted to use Clack initially anyway, I re-wrote it to use Clack and websocket-driver. |
@thegoofist cool! |
hm @thegoofist can you put in another PR to add websockets.md to the index.md link list? I should have caught that, I had forgotten we didn't autogen our index page |
Ack. Oh right. Np. Just a sec. |
Very useful and welcome, thanks ! about quoting simple quotes: this library gives pythonic triple-quotes: https://github.com/smithzvk/pythonic-string-reader FYI I posted the tutorial on reddit, we might have feedback: https://www.reddit.com/r/Common_Lisp/comments/ctyzz7/websockets_tutorial_with_websocketdriver_the/ |
I ended up noticing some activity on the Woo repo that lead me to believe my initial trouble wasn't with Clack+websocket-driver but was instead with Woo, so that the issues raise din #255 are probably not relevant.
Hence, I have rewritten the tutorial to use Clack and websocket-driver !