Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Scolling on mobile brings up menu #1261 #1623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddenev
Copy link

@ddenev ddenev commented Jun 19, 2024

ddenev Quick ddenev /master → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 6 Label Unchecked Tasks Powered by Pull Request Badge

Category:

One of: Bugfix

Overview

Added an event listener for pointermove in src/directives/LongPress.js to take care of swiping on mobile devices.

Issue Number (if applicable) #1261

New Vars (if applicable)

none

Screenshot (if applicable)

none

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@ddenev ddenev requested a review from Lissy93 as a code owner June 19, 2024 14:46
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit b32852c
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6672ef4de9b365000816330c
😎 Deploy Preview https://deploy-preview-1623--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CrazyWolf13 CrazyWolf13 changed the title fixes #1261 [Fix] Scolling on mobile brings up menu #1261 Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant