Adjusting SSL Portion of HealthCheck

[dintho]

Category:

Bugfix

Overview

I ran into a issue running dashy in a podman oci container with the default value for public & private key paths not being set the same way in healthcheck.js vs ssl-server.js

This difference was allowing SSL to start but causing the healthcheck to get a 302 redirect to https as the criteria for checking
the isSsl in healthcheck.jswas not the same as whatenableSSLis using inssl-server.js`

hopefully this change removes the need for SSL_PUB_KEY_PATH & SSL_PRIV_KEY_PATH to also be set as env vars in the compose file (although i assume with the nature of how the check is currently written bare metal installs have the same issue)

Issue Number (if applicable) #00

This probably solves #843 and #1410 i do not think this totally solves #768.

i had a hard time following that thread on #768 and if it is the same issue then awesome!!! but if not may need to unlink it from the other 2 issues because issue scope creep might be a thing there.

side note: if this does not solve #768 please let me know if i can be of any help there as well. i wasnt able to follow it and understand how it was related to the SSL issues but am happy to help with it if i can

New Vars (if applicable)

this change copies const fs & const httpsCerts from ssl-server.js and adjusts the logic of const isSsl

side note: i realize httpsCerts is probably not the right name for the constant in healthcheck.js but i kept it the same as ssl-server.js to hopefully help maintainability in the future by others

Screenshot (if applicable)

N/A

Code Quality Checklist (Please complete)

• All changes are backwards compatible
• All lint checks and tests are passing
• There are no (new) build warnings or errors
• (If a new config option is added) Attribute is outlined in the schema and documented
• (If a new dependency is added) Package is essential, and has been checked out for security or performance
• (If significant change) Bumps version in package.json

[netlify]

✅ Deploy Preview for dashy-dev ready!

Name	Link
🔨 Latest commit	a130d6c
🔍 Latest deploy log	https://app.netlify.com/sites/dashy-dev/deploys/67cf777ba73ee30008956f52
😎 Deploy Preview	https://deploy-preview-1827--dashy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.