Fix: Use dns.promises in mail-config to prevent callback error #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mail-config` job crashes because it uses `await dns.resolveMx` which requires the Promise API, but the default import provides the Callback API.
Error observed: `The "callback" argument must be of type function. Received undefined`
This PR switches the import to `{ promises as dns }` to support the async/await usage present in the code.
✅ Deploy Preview for web-check ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mail-configjob crashes because it usesawait dns.resolveMxwhich requires the Promise API, but the default import provides the Callback API.Error observed:
The "callback" argument must be of type function. Received undefinedThis PR switches the import to
{ promises as dns }to support the async/await usage present in the code.