fix(wizard): move semantic_search config out of ~/.claude/settings.json#12
Merged
fix(wizard): move semantic_search config out of ~/.claude/settings.json#12
Conversation
WHAT CHANGED:
1. opc/scripts/setup/wizard.py:
- Semantic search config now writes to ~/.config/tldr/config.json
instead of ~/.claude/settings.json
- Added cleanup: removes stale "semantic_search" key from
~/.claude/settings.json if present from previous installations
- WHY: Claude Code does not recognise the "semantic_search" key
and reports the settings file as invalid ("Found N invalid
settings files"). The tldr daemon reads per-project config
from <project>/.tldr/config.json at runtime anyway.
CONTEXT:
The wizard was injecting a non-standard key into Claude Code's
global settings file. Claude Code validates its settings schema
and flags unknown keys, causing a warning on every startup.
The daemon's default config already matches the wizard's defaults
(bge-large-en-v1.5, threshold=20), so the global write was mostly
redundant — but the GPU-detection logic (choosing all-MiniLM-L6-v2
for CPU-only systems) is preserved in the new location.
Lisztos
force-pushed
the
fix/semantic-search-config
branch
from
9716b32 to
a72a4ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from parcadei/Continuous-Claude-v3#137 by @tkavelli
Summary
Wizard now writes semantic search config to
~/.config/tldr/config.jsoninstead of~/.claude/settings.json. Also cleans up stalesemantic_searchkey from previous installations.Problem
The wizard injects a
semantic_searchkey into~/.claude/settings.json(Claude Code's global settings). Claude Code does not recognise this key and reportsFound N invalid settings fileson every startup. Additionally, thetldrdaemon reads this config from a different location, so the global write never reached the daemon.Test plan
~/.config/tldr/config.json~/.claude/settings.jsondoes not containsemantic_searchkey