Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #10

Merged
merged 57 commits into from
Jul 15, 2020
Merged

Dev #10

merged 57 commits into from
Jul 15, 2020

Conversation

Liupold
Copy link
Owner

@Liupold Liupold commented Jul 12, 2020

Improvements:

  • CLI like flags support
  • loop is now build in
  • pstree parsing is much more stable thanks to SeerLite
  • pipe support.
  • Typo fixed.
  • Super simple to use and install.

Liupold and others added 30 commits July 10, 2020 12:11
@Liupold
speed improvement with readability.
e8d0857
@Liupold
Calculate ppid only if swallow able.
0bf0bf6
@Liupold
Reverse order search, (more consistent time).
273831c
@Liupold
Around 10ms time improvement.
303e3d9
@Liupold
fixed a unnecessary variable.
098833a
@Liupold
proc to ps and blacklist is now as most efficient place.
cee91b8
@Liupold
Added a fully-functional cli like option with loop, simple to install.
d6c3576
@Liupold
updated README.
6700454
@SeerLite
Remove xprop_ret by reordering some lines
1cd2bf1
@SeerLite
Return in case window has no _NET_WM_PID
71709d3
@SeerLite
toggle: Switch to an if-else so return code works
2651018
@SeerLite
toggle: exit "$?" -> return "$?"
dad8f83 
Not sure how to handle return statuses yet but I know it's better to
return it to main than exit from inside a function.
@SeerLite
Fix some non-flag argument handling
37bc591
@SeerLite
Fix a bunch of typos
63faf53
@SeerLite
Fix --vomit
01bad15
@SeerLite
vomit: Remove unnecessary return 0 statement
d715c66
@SeerLite
Have sed handle subprocesses in pstree output
4a69df2
@Liupold
Merge pull request #9 from SeerLite/dev
d3a4bfa 
General fixes
@Liupold
Fixed unnecessary '$?'.
08299c2
@Liupold
Meaningful return code for swallow()
3fa266b
@Liupold
basic pipe support with README update.
867c635
@Liupold
README typo fix.
2fbd67c
@Liupold
Proper fix for focus jumping on toggle.
658dde8
@Liupold
fixed the previous commit.
936277e
@Liupold
xargs is no longer needed.
1e6bf5b
@Liupold
execution time(s) updated.
4c2c34e
@Liupold
fix for ghosting error caused due to previous $ppid.
7d06e4a
@Liupold
a bit more effective loop.
adf11bf
@Liupold
basic shellcheck.
9dff523
@Liupold
added problem-matcher.json (from action-shellcheck)
1c4866b
@Liupold
Merge pull request #11 from SeerLite/dev
38bde41 
Small fixes , fix for multiple flag ghosting.
@Liupold
Copy link
Owner Author

Liupold commented Jul 13, 2020

This should fix #2 .

@Liupold
Copy link
Owner Author

Liupold commented Jul 14, 2020 •
edited
Loading

Did it mess up the performance too much or do you think this method is better?

I didn't know it was executing on each even (my poor testing). It wasn't slow but on a laptop its counts (specialty on battery). Moreover I this is much more effective as someone might accidentally run pidswallow --loop twice. This is just simply not possible now. What do you think?

@Liupold Liupold marked this pull request as ready for review July 14, 2020 05:04
@SeerLite
Copy link
Collaborator

Did it mess up the performance too much or do you think this method is better?

I didn't know it was executing on each even (my poor testing). It wasn't slow but on a laptop its counts (specialty on battery). Moreover I this is much more effective as someone might accidentally run pidswallow --loop twice. This is just simply not possible now. What do you think?

Oh I completely missed this reply haha, sorry! Good thing we figured out doesn't use too many resources.
I also did some quick tests by monitoring htop now, and I think it's all fine. The only way the script could start causing problems is if there's lots of constant window/wm/xorg activity, and at that point I'm sure it's gonna be Xorg or even bspwm using more resources than our little script heh

IMO it's all ready to be merged now!

@Liupold Liupold merged commit 02fd8a2 into master Jul 15, 2020
@Liupold
Copy link
Owner Author

Liupold commented Jul 15, 2020

Merged, thanks a lot for all that awesome job.

Liupold added a commit that referenced this pull request Jul 23, 2020
@Liupold
Merge pull request #18 from Liupold/master
2fbfe2b 
Merge pull request #10 from Liupold/dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Liupold @SeerLite