Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add openapi specification #3540

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 16, 2025

Description

This PR will attempt to provide an openapi spec for the Sunshine rest API. I am not an expert on this, but I believe once this is available it will be possible to automatically create SDKs in various languages using an SDK generator (https://openapi.tools/#sdk).

The idea came from https://plexapi.dev/Open-API-Specification which generates SDKs using "Speakeasy". Unfortunately, I don't believe Speakeasy has a generous open source license/option, so other generators may need to be considered. Still, the repo has been a good example, starting with the main spec file - https://github.com/LukeHagar/plex-api-spec/blob/main/src/pms-spec.yaml

Additionally, there are spec generators for various languages, but none seem to be available for c++, understandably, so this is being manually created.

TODO:

Other notes:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.62%. Comparing base (257a102) to head (5b863f7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3540   +/-   ##
=======================================
  Coverage   11.62%   11.62%           
=======================================
  Files          93       93           
  Lines       17319    17319           
  Branches     8085     8085           
=======================================
  Hits         2014     2014           
  Misses      12823    12823           
  Partials     2482     2482           
Flag Coverage Δ
Linux 11.30% <ø> (ø)
Windows 13.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the feat/api/add-openapi-specification branch 4 times, most recently from 5121bda to 4fa0df4 Compare January 17, 2025 03:10
@ReenigneArcher ReenigneArcher added this to the stable release milestone Jan 23, 2025
@ReenigneArcher ReenigneArcher force-pushed the feat/api/add-openapi-specification branch from 4fa0df4 to 25dfcf6 Compare January 23, 2025 01:04
@ReenigneArcher ReenigneArcher force-pushed the feat/api/add-openapi-specification branch from 25dfcf6 to 5b863f7 Compare February 1, 2025 15:08
Copy link

sonarqubecloud bot commented Feb 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant