fix(process): refactor away the bugs and race conditions in proc_t #3604
+491
−294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of #3417.
Moved the code around to remove possible race conditions and bad patterns in general. I tried to not change the logic at all if possible, therefore while some of the sonarqube suggestions are valid, will not be addressed.
Screenshot
Since I have moved stuff around to be in the same order as a header, the diff can be hard to read. These are the screenshots I used for checking for changes (for the "refactoring" commit only):
Issues Fixed or Closed
Resolves this PR: #3417
Type of Change
.github/...
)Checklist