minor optimisations #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xngmi
reviewed
Nov 19, 2022
| @@ -29,8 +29,13 @@ contract LlamaLendFactory is Ownable { | |||
| } | |||
|
|
|||
| function emergencyShutdown(address[] calldata pools) external onlyOwner { | |||
| for(uint i = 0; i < pools.length; i++){ | |||
| LendingPool(pools[i]).emergencyShutdown(); | |||
| uint length = pools.length; | |||
There was a problem hiding this comment.
i expect to never call this method, and if i call it will be one-off so gas doesnt matter much
| @@ -40,7 +40,7 @@ contract ListNfts { | |||
| owner, | |||
| balance | |||
| ); | |||
| if (tokenId >= start && tokenId < end) { | |||
| if (tokenId < end && tokenId >= start) { | |||
There was a problem hiding this comment.
this contract is never called on-chain
| @@ -101,7 +101,7 @@ contract LendingPool is OwnableUpgradeable, ERC721Upgradeable, Clone { | |||
| } | |||
|
|
|||
| function calculateInterest(uint priceOfNextItems) internal view returns (uint interest) { | |||
| uint borrowed = priceOfNextItems/2 + totalBorrowed; | |||
| uint borrowed = (priceOfNextItems >> 1) + totalBorrowed; | |||
There was a problem hiding this comment.
good point, does this have any side effects?
There was a problem hiding this comment.
DIV operator costs 5 gas while SHR costs 3 gas, so that saves 2 gas. And if that's called multiple times it'd sure amount to much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes were made that would save some gas. It's not much, but it's honest work.