Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomb: death check for cursed phalanx detector #101

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

FiveNine
Copy link
Contributor

@FiveNine FiveNine commented Aug 2, 2024

Issue:

Currently the "Detect Cursed Phalanx" feature only looks if you already have a cursed phalanx in inventory or a kitted fang. However, if you complete a 500 invocation raid even though you or a raid member had a death, it will still ask you to drop your kit before looting which is slightly annoying when you know it isnt a kit raid.

Solution:

This fix continuously checks for any player death utilizing the player orbs' varbits during the raid. If there was a single death, it will not ask you to drop your kit before looting a 500 invocation level raid.

@FiveNine
Copy link
Contributor Author

FiveNine commented Aug 2, 2024

For some reason the ctor to replace the Injected fields was making the build fail so I reverted that change for now.

@LlemonDuck
Copy link
Owner

Two things:

  • checking whether the raid room is null is potentially faulty due to some loading shenanigans where the game teleports you around a few times, but the isInRaid value should account for that
  • Health values are also potentially faulty due to disconnects (e.g. afaik, disconnecting and reconnecting in the nexus does not count as a death, but does show 0 health iirc?), so I switched to using the deaths chat message instead

Thanks for the PR!

@LlemonDuck LlemonDuck merged commit efc7548 into LlemonDuck:main Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants