Things I Learned At Code Review

Jump to bottom Edit New page

ctide edited this page Sep 9, 2011 · 3 revisions

less code is more code, collapse small functions into main code flow when possible
path.join for all fs paths
https://github.com/LockerProject/Locker/commit/116da620877cb48ca6cf6f4107391f5c34a0a1b8 is the code changes that resulted from this code review, as well as a need to change some things in synclet/datastore to be a little more coherent (https://github.com/LockerProject/Locker/commit/c91305313d5ec96241c8807d2d7be819cca54063)