Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC-245: Update OC preview version and fix breaking changes #265

Merged
merged 66 commits into from
Jul 28, 2024
Merged

OCC-245: Update OC preview version and fix breaking changes #265

merged 66 commits into from
Jul 28, 2024

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig commented May 28, 2024 •
edited by jira bot
Loading

@github-actions github-actions bot changed the title Update OC preview version and fix breaking changes OCC-245: Update OC preview version and fix breaking changes May 28, 2024
@Piedone
Copy link
Member

Piedone commented Jun 3, 2024

FYI after updating to the latest preview packages, you'll need to change TotalOfContentTypeBuilder to have this signature for Build(), with ISchema schema, added (nothing else needed):

public void Build(ISchema schema, FieldType contentQuery, ContentTypeDefinition contentTypeDefinition, ContentItemType contentItemType)

Same for ContentItemTypeBuilder in the Training Demo.

@sarahelsaig
Update OC preview version.
e626beb
@sarahelsaig
Update after API change.
31bcc5e
@sarahelsaig
Merge branch 'task/system-text-json-migration' into issue/OCC-245
655dbd7
@sarahelsaig
Merge branch 'task/system-text-json-migration' into issue/OCC-245
98c6f06
@sarahelsaig
Copy NuGet.config.
db22445
@sarahelsaig
Tyy adding package source mapping too.
ad32829
@sarahelsaig
diagnostics
43319a1
@sarahelsaig
diagnostics
324cf80
@sarahelsaig
also restore
1782b5b
@sarahelsaig
more testing
e58446d
@sarahelsaig
Revert nuget.config chages.
b985722
@sarahelsaig
Merge branch 'task/system-text-json-migration' into issue/OCC-245
b327d1a
@sarahelsaig
Copy NuGet.config from NEST.
66ce87d
@sarahelsaig
Update OC version.
50d1347
@sarahelsaig
Update class after interface change.
d225f86
@sarahelsaig
Update OC version.
40eb6c7
@sarahelsaig
LocalizedHtmlStringConverter is not needed.
f86de9a
@sarahelsaig
Update OC preview version.
c1bfc94
@sarahelsaig
Update OC preview version.
0699806
@sarahelsaig
Merge remote-tracking branch 'origin/issue/OCC-245' into issue/OCC-245
a81eb67 
# Conflicts:
#	Lombiq.HelpfulLibraries.LinqToDb/Lombiq.HelpfulLibraries.LinqToDb.csproj
#	Lombiq.HelpfulLibraries.OrchardCore/Lombiq.HelpfulLibraries.OrchardCore.csproj
@sarahelsaig
Remove LocalizedHtmlStringConverter reference.
f26e618
sarahelsaig and others added 2 commits July 28, 2024 22:17
@sarahelsaig @Piedone
Update .github/workflows/publish-nuget.yml
923d3f0 
Co-authored-by: Zoltán Lehóczky <[email protected]>
@sarahelsaig
Make ShapeTables created by PerTenantShapeTableManager frozen
b7e6247 
to match DefaultShapeTableManager where this change was made in PR OrchardCMS/OrchardCore#15651.
@Piedone Piedone merged commit 2a3dee8 into task/system-text-json-migration Jul 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahelsaig @Piedone