Skip to content

Commit

Permalink
Merge pull request #44 from Lomkit/feature/detail-s
Browse files Browse the repository at this point in the history
✨ renames detail to details
  • Loading branch information
GautierDele authored Sep 16, 2023
2 parents faa3a5f + 7a10bb9 commit dab2a25
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/Concerns/PerformsRestOperations.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ trait PerformsRestOperations
*
* @return array
*/
public function detail(DetailRequest $request)
public function details(DetailRequest $request)
{
$request->resource($resource = static::newResource());

Expand Down
8 changes: 4 additions & 4 deletions src/Http/Routing/ResourceRegistrar.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class ResourceRegistrar extends BaseResourceRegistrar
*
* @var string[]
*/
protected $resourceDefaults = ['detail', 'search', 'mutate', 'operate', 'destroy', 'restore', 'forceDelete'];
protected $resourceDefaults = ['details', 'search', 'mutate', 'operate', 'destroy', 'restore', 'forceDelete'];

/**
* The verbs used in the resource URIs.
Expand All @@ -29,7 +29,7 @@ class ResourceRegistrar extends BaseResourceRegistrar
];

/**
* Add the detail method for a resourceful route.
* Add the details method for a resourceful route.
*
* @param string $name
* @param string $base
Expand All @@ -38,13 +38,13 @@ class ResourceRegistrar extends BaseResourceRegistrar
*
* @return \Illuminate\Routing\Route
*/
protected function addResourceDetail($name, $base, $controller, $options)
protected function addResourceDetails($name, $base, $controller, $options)
{
$uri = $this->getResourceUri($name);

unset($options['missing']);

$action = $this->getResourceAction($name, $controller, 'detail', $options);
$action = $this->getResourceAction($name, $controller, 'details', $options);

return $this->router->get($uri, $action);
}
Expand Down

0 comments on commit dab2a25

Please sign in to comment.