Fixed duplicate route creation issue in QuickStartCommand

[erhanurgun]

Hello,

I've identified an issue in the QuickStartCommand and created this pull request to address it. Here are the changes I've made:

1. In QuickStartCommand.php:

   • Added a new method called updateApiRoutes(). This method checks if the 'users' route already exists and only adds it if it doesn't.
   • This new method inspects the routes/api.php file and only appends the new route when necessary.

2. Added QuickStartCommandTest.php:

   • Included a test method to ensure the command creates the correct files.
   • Added a test method to verify that API routes are updated correctly.
   • Included a test method to check that routes are not duplicated when the command is run multiple times.

These changes will ensure the command operates more reliably and reduce the likelihood of similar issues occurring in the future.

I'm looking forward to your feedback and review. If you have any questions or suggestions, please don't hesitate to ask.

Thank you!

[GautierDele]

Hello @erhanurgun,

Thanks for your proposal, seems like a good idea
It seems that your tests arnt passing, could you have a look at it please ?

[erhanurgun]

Hello @GautierDele,

Thank you for your feedback. I've reviewed the tests and made some adjustments to address the failing tests. Here's a summary of the changes I've made:

1. In ./phpunit.xml:21:

   • Added environment variables for testing:

     <env name="APP_ENV" value="testing"/>
     <env name="DB_CONNECTION" value="testing"/>

2. In ./src/Console/Commands/QuickStartCommand.php:109:

   • Updated the file creation logic:

     file_put_contents($routesPath, '<?php');

3. In both ./tests/Features/Commands/QuickStartCommandTest.php:14 and ./tests/Feature/TestCase.php:14:

   • Added a check to ensure api.php exists before running tests:

     if (! File::exists(base_path('routes/api.php'))) {
         File::put(base_path('routes/api.php'), '<?php');
     }

4. In ./tests/Feature/TestCase.php:28:

   • Added getPackageProviders and getEnvironmentSetUp methods to properly configure the testing environment.

These changes aim to resolve the "File does not exist at path .../routes/api.php" error that was causing the tests to fail.

I've pushed these updates to my fork. Could you please pull the changes and run the tests again? If you encounter any issues or have any questions, please let me know, and I'll be happy to assist further.

Thank you for your patience and collaboration.

Best regards,

---

Screenshots from the tests

[GautierDele]

I'm gonna have a quick look later this afternoon in order to test it on my side, thanks for your time
I'm gonna also fix the problem i gave above, so you don't need to 😉

[GautierDele]

Thanks @erhanurgun merging !