Added DevSecOps Jenkinsfile with Email Notifications #9
Open
Nehabisen21 wants to merge 2 commits intoLondheShubham153:mainfrom
Open
Added DevSecOps Jenkinsfile with Email Notifications #9Nehabisen21 wants to merge 2 commits intoLondheShubham153:mainfrom
Nehabisen21 wants to merge 2 commits intoLondheShubham153:mainfrom
Conversation
Nehabisen21
changed the title
Nehabisen21
changed the title
| steps{ | ||
| dir("/var/lib/jenkins/workspace/App/frontend"){ | ||
| //ECR Login | ||
| sh 'aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws/m5h4e3m3' |
Owner
There was a problem hiding this comment.
how will the login credentials be passed?
the use of environment variables is needed
Author
There was a problem hiding this comment.
No sir, its for AWS ECR.
It worked fine.
LondheShubham153
requested changes
Jan 17, 2024
Owner
LondheShubham153
left a comment
LondheShubham153
left a comment
There was a problem hiding this comment.
the DevSecOps pipeline needs prerequisites
- SonarQube Installation
- Env Variables
- Readme Changes
We need to add it as DevOps Engineers, else the end user will be confused
| sh 'kubectl create namespace workshop' | ||
| sh 'kubectl apply -f secrets.yaml' | ||
| sh 'kubectl apply -f deploy.yaml' | ||
| sh 'kubectl apply -f service.yaml' |
Owner
There was a problem hiding this comment.
we need readme docs for kubeconfig adding to Jenkins,
| <li>Build Logs: ${BUILD_URL}</li> | ||
| </body> | ||
| </html>''', | ||
| to: 'bisen.neha21@gmail.com', |
Author
There was a problem hiding this comment.
Generally we use this way only sir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added DevSecOps pipeline