Skip to content

Change base image to Eclipse Temurin 17 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Loki180128 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change base image to Eclipse Temurin 17 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Use the official OpenJDK 17 image as the base image
FROM openjdk:17-jdk-alpine
FROM eclipse-temurin:17-jdk-alpine
Comment on lines 1 to +2
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

eclipse-temurin 17-jdk-alpine Docker image

💡 Result:

eclipse-temurin:17-jdk-alpine is a valid Docker Official Image tag (Temurin JDK 17 on Alpine). You can use it like:

FROM eclipse-temurin:17-jdk-alpine

For better reproducibility, pin to a specific Alpine release and/or Temurin patch tag, e.g. 17-jdk-alpine-3.23 or 17.0.18_8-jdk-alpine. [2]

Notes:

  • The -alpine variants are based on Alpine Linux (small footprint). [1]
  • Alpine uses musl (not glibc), which can cause compatibility issues with some native dependencies; if you need maximum compatibility, consider a Debian/Ubuntu-based Temurin tag (for example eclipse-temurin:17-jdk or 17-jdk-jammy). [3]

Update comment to reflect the new base image.

The comment on line 1 references "official OpenJDK 17 image" but the base image has been changed to Eclipse Temurin. Update the comment for consistency.

📝 Proposed fix 
-# Use the official OpenJDK 17 image as the base image
+# Use the Eclipse Temurin 17 image as the base image
 FROM eclipse-temurin:17-jdk-alpine
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Use the official OpenJDK 17 image as the base image
FROM openjdk:17-jdk-alpine
FROM eclipse-temurin:17-jdk-alpine
# Use the Eclipse Temurin 17 image as the base image
FROM eclipse-temurin:17-jdk-alpine
🧰 Tools
🪛 Trivy (0.69.2)

[error] 1-1: Image user should not be 'root'

Specify at least 1 USER command in Dockerfile with non-root user as argument

Rule: DS-0002

Learn more

(IaC/Dockerfile)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile` around lines 1 - 2, The top-line comment incorrectly says
"official OpenJDK 17 image"; update the Dockerfile comment to reference the
actual base image used (e.g., "Eclipse Temurin OpenJDK 17 image") so it matches
the FROM statement (FROM eclipse-temurin:17-jdk-alpine); modify the comment text
above the FROM line to mention "Eclipse Temurin" and optionally "OpenJDK 17" for
clarity.


# Set metadata
LABEL maintainer="trainwithshubham@gmail.com"
Expand Down