Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update todo.ejs #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update todo.ejs #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/todo.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
</head>

<body>
<h1>Hello Junoon Batch 8 (Jenkins), Write your plan on Learning Jenkins</h1>
<h1>Hello Junoon Batch 8 (Jenkins) wala, Write your plan on Learning Jenkins</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consider maintaining professional language in the heading.

While the HTML structure is correct and the change doesn't affect functionality, consider keeping the heading text professional and consistent with standard business communication. The addition of "wala" makes the tone informal, which might not be appropriate depending on the application's context and target audience.

-        <h1>Hello Junoon Batch 8 (Jenkins) wala, Write your plan on Learning Jenkins</h1>
+        <h1>Hello Junoon Batch 8 (Jenkins), Write your plan on Learning Jenkins</h1>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<h1>Hello Junoon Batch 8 (Jenkins) wala, Write your plan on Learning Jenkins</h1>
<h1>Hello Junoon Batch 8 (Jenkins), Write your plan on Learning Jenkins</h1>

<ul>
<% todolist.forEach(function(todo, index) { %>
<li>
Expand Down