Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update progressCell for bolus display #2295

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Conversation

marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Mar 21, 2025

Purpose:

This PR fixes an intermittent bolus progress display error reported in these issues

@itsmojo identified root cause for this intermittent display error and passed on a proposed fix for the main branch which is found in PR 2264.

If a bolus progress is being displayed when the app is put into background and then the app is opened in the middle of a bolus, the progress bar shows a stale value of the expected total units; the stale value is the total units from the last time the bolus progress bar was displayed.

This PR is one of 3. One each to main (closed without merging), tidepool-merge (PR #2263) and dev (this one).

I was incorrect in this next statement.
They all have the same fix which has been tested extensively.

The code change for tidepool-merge is different from that needed for main and dev and I mistakenly copied the tidepool-merge changes over. See #2298 for the correction needed for the dev branch.

@marionbarker marionbarker requested a review from ps2 March 21, 2025 14:20
Copy link
Collaborator

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker marionbarker merged commit e55ea0c into dev Mar 21, 2025
@marionbarker marionbarker deleted the fix_dev/ui_bolus_display branch March 21, 2025 20:20
@marionbarker
Copy link
Contributor Author

marionbarker commented Mar 22, 2025

Apologies - I rushed this through without testing properly.

The original patch that @itsmojo gave me, did work for dev. But I had to modify it to make it work for tidepool-merge branch. I had forgotten this.

FYI - @ps2:

  • This PR as merged does not build in LoopWorkspace.

Linking the PR to keep track:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants