fix: show "vi" instead of lotus emoji on GNOME top bar indicator

[ductrantrong]

Summary

• On Ubuntu 24.04 Wayland, the GNOME Shell top bar cannot render the 🪷 emoji (U+1FAB7, Unicode 14.0) used as the Vietnamese mode label, causing it to display as "?" while English correctly shows "en"
• Replace the emoji with "vi" to follow fcitx5 convention (en, ja, ko) and ensure compatibility across all desktop environments

Changes

• src/lotus-engine.cpp: Change subModeLabelImpl default return from "🪷" to "vi"

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a display compatibility issue where the Vietnamese input mode indicator, previously an emoji, failed to render correctly on certain GNOME environments. By switching to a text-based label, the change ensures that users consistently see the correct language indicator, improving the user experience and adhering to established conventions for input method display.

Highlights

• Display Compatibility Fix: Replaced the '🪷' emoji with the text 'vi' for the Vietnamese input mode indicator in the GNOME top bar to resolve rendering issues on Ubuntu 24.04 Wayland, where the emoji was displaying as '?'.
• Standardization: Adopted the 'vi' text label to align with fcitx5's convention for language indicators (e.g., 'en', 'ja', 'ko'), ensuring consistent and reliable display across various desktop environments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[ductrantrong]

🪷 -> ?

[gemini-code-assist]

Code Review

This pull request changes the Vietnamese input mode label from a lotus emoji ('🪷') to the string 'vi'. This is intended to fix a rendering issue on GNOME Wayland where the emoji was not displayed correctly. The change is a one-line modification in src/lotus-engine.cpp. The new label 'vi' is consistent with conventions for other language indicators and should resolve the compatibility problem. My review of the code change did not identify any issues.

[nhktmdzhg]

cái này nên để là vi nếu đang dùng gnome thôi, không nên luôn đặt là vi, bởi vì ở các DE/WM Khác thì nó hiện icon trên taskbar chứ không phải chữ

[ductrantrong]

Updated to only fall back to "vi" on GNOME, where the top bar can't render the 🪷 emoji. Other desktops (KDE, etc.) will now correctly show the lotus emoji.

Changes:

• Detect GNOME at startup via XDG_CURRENT_DESKTOP
• Return "vi" on GNOME, "🪷" elsewhere

[nhktmdzhg]

@ductrantrong bạn sửa lại pr nhắm vào dev nhé, 0 được nhắm vào main.

Cái này mình đã để cập trong CONTRIBUTING.md rồi