DO NOT MERGE TO-5870 Added server keepAlive timeout #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidoram
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
The purpose of this change, is setting the timeout value that is used when the edge-splitter is waiting for incoming data before it decides that no more data is coming and terminates the connection with a 504.
This is so that the load balancer will receive a 504 from the edge-splitter if it does timeout, rather than a generic 502. This will help us figure out if there is some delay in sending data through to the edge-splitter.
Changed the server keepAlive timeout value from the default value of 5s, to a configurable value - TO-5870
We have marked this as do not merge because this branch is only suitable for a POC in
edge, because we have been unable to get the tests passing, either locally or in travis. We even tried to reproduce the exact conditions when the tests last passed in Nov 16th 2016, but to no avail :-(