fix(usbdevice): use glob for android_usb state instead of hardcoded android0#4
Open
frankurcrazy wants to merge 2 commits intoLubanCat:debian12from
Open
Conversation
The hid_prepare() function uses echo -ne to write the HID report descriptor binary data. On systems where /bin/sh is dash (not bash), echo does not support -ne flags, causing the descriptor to be written as literal ASCII text (e.g., "-ne \x05\x01\x09\x06...") instead of binary bytes. This breaks HID keyboard emulation entirely — the USB host cannot parse the descriptor, sends infinite bus resets, and writes to /dev/hidg0 block indefinitely. Replace echo -ne with printf using octal escapes, which work correctly across all POSIX shells (bash, dash, sh). Fixes: LubanCat#1
…ndroid0 The kernel uses a monotonic counter (gadget_index++) to name android_usb devices. If the configfs gadget directory is removed and recreated, the device becomes android1, android2, etc. The hardcoded path /sys/class/android_usb/android0/state then fails silently, leaving USB_STATE empty and causing usbdevice update to misbehave. Use a glob pattern (android*/state) to match whichever androidN device exists. Fixes: LubanCat#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sys/class/android_usb/android0/stateto use glob patternProblem
The kernel's
gadget_indexcounter indrivers/usb/gadget/configfs.cis monotonic — if the configfs gadget directory is removed and recreated, theandroid_usbdevice becomesandroid1,android2, etc. The hardcodedandroid0path then fails silently, leavingUSB_STATEempty.Fix
Fixes #3