explicitly provide type argument to avoid breakage in future Rust versions#2
Open
lcnr wants to merge 1 commit intoLuisDuarte1:mainfrom
Open
explicitly provide type argument to avoid breakage in future Rust versions#2lcnr wants to merge 1 commit intoLuisDuarte1:mainfrom
lcnr wants to merge 1 commit intoLuisDuarte1:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D1Backendhas multiple where-bounds forHasSqlTypedue to the super-traits ofdiesel::backend::Backend:HasSqlType<SmallInt>,HasSqlType<Integer>, and others. It also has one where-bound which references a generic parameter, i.e. which is non-global:HasSqlType<T>.The compiler previously preferred such non-global where-bounds over global1 where-bounds in some cases, guiding type inference. This behavior was quite subtle and inconsistent, so we've reworked the implementation in rust-lang/rust#132325.
Because of this, we no longer infer the type argument of
<D1Backend as HasSqlType<_>>::metadatatoTas usingSmallIntorIntegeris just as valid and would also allow this code to compile. The change in inference behavior will likely be stable in version 1.85. This PR modifies your code to make the used type explicit, allowing your crate to compile in future Rust versions.Footnotes
pretty much: a where-bound which does not mention any generic parameters ↩