Merged
Conversation
- The large `macros/lib.rs` was split into multiple smaller files - To avoid relying on parsing `syn::Expr`, there are declarative macros in `bunt` which slightly process the macro input and delegate it to the proc macros. In particular, all expressions are wrapped into groups, making it easy to skip in the proc macro parser. - There are not `print[ln]` proc macros anymore as these convenience macros can easily be implemented as decl macros in `bunt`. Despite this huge diff, lots of code stayed the same and was just moved somewhere.
This is only possible thanks to the refactor work in the previous commits.
Owner
Author
|
Interesting: these changes accidentally require a rustc patch released with 1.46.0. From the changelog:
This is required as we know call the proc macros from decl macros. This requirement is also the reason for why CI fails: the GitHub runner still runs on 1.45.2. The runners should be updated weekly, however, so I will just wait a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Fixes #4
See commit messages for more information.