feature: capture HTTP version in Request #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows responding with info about the HTTP version. Additionally, expanded a test to cover this. Note: in the test, we assert resp.version(). However, for my use case I have `test client --> reverse proxy under test --> wiremock`, so I do not have direct access to the response from wiremock. Hence, I want to put more info about the request into the response body/headers.
Owner
|
I agree with the change, but unfortunately it'd be a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows responding with info about the HTTP version.
Additionally, expanded a test to cover this.
Note: in the test, we assert resp.version(). However, for my use case I have
test client --> reverse proxy under test --> wiremock, so I do not have direct access to the response from wiremock. Hence, I want to put more info about the request into the response body/headers.