Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository cleanup #60

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Repository cleanup #60

wants to merge 2 commits into from

Conversation

nicandris
Copy link

  • Moved screenshots in their own folder to clean root directory
  • Changed urls for images in README to file references

@Luligu
Copy link
Owner

Luligu commented Jun 25, 2024

Hi,
thanks but is not working on npm.
The readme is also available there:
https://www.npmjs.com/package/matterbridge
and there the screenshot directory doesn't exist nor the Screenshot*.jpg and Screenshot*.png.
See .npmignore

@Apollon77
Copy link

@Luligu That should fix itself when you merge this directly before the next release :-)

@Luligu
Copy link
Owner

Luligu commented Jun 26, 2024

No cause there is not

  • ./frontend/public/matterbridge 64x64.png in npm package
  • ./screenshot/Screenshot home.jpg in npm package
    I make the published package as slim as possible.
    This is why the link are to GitHub.
    So if you want cleanup and move all jpg to the screenshot directory (good for me as I told you) you need to keep the link with full path to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants