Fix the error in reports.full()

[AndreBBM]

This Pull requests Fixes #55

Changes:

• Cast float to "returns.min()" and to "benchmark.min()"

As described in the issue, line 361 in core.py was comparing a <class 'numpy.float64'> with a <class 'pandas.core.series.Series'>, which was causing an error.

Simply casting a float to both variables ensures that the comparison is made between equal types and fixes the issue without breaking the reports.html() function mentioned in the issue.

Description by Korbit AI

What change is being made?

Convert minimum and maximum return and benchmark values to floats in plot_timeseries() within core.py to fix error in reports.full().

Why are these changes being made?

The error was caused by incompatible data types used for y-axis limit calculations; converting these values to floats ensures compatibility and accuracy in plotting. This change addresses the issue without affecting related functionalities, providing a simple and effective solution.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
quantstats_lumi/_plotting/core.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	✅

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]