chore: Add loading spinner to index.html #59
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for lively-starlight-93e01a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came here because of this video of theo: https://youtu.be/mvqPWay9ABI?si=wiPwwABnu7CIh4BQ, I want to contribute with this project and I was thinking about making a simple mod in index.html where you can load a pure css spinner that can appear for the user before the React Three Fiber loader starts and make its own things.
I thought about it because a lot of people with bad connection will instead see a white screen with no clue about what's happening and may think the site is just broken an leave the site before the experience even begin.
example without the css spinner:
simulating a 3G network, the user may have to wait for more than 20 seconds to even see the R3F loading screen