Skip to content

Fix propagation not happening #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ildyria merged 3 commits into from
Jan 4, 2026
Merged

Fix propagation not happening #3933

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7996832
fix propagation not happening
ildyria Jan 4, 2026
9824fb6
formatting
ildyria Jan 4, 2026
7eaa955
WRTC
ildyria Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/Actions/Photo/Pipes/Shared/Save.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

use App\Contracts\PhotoCreate\PhotoDTO;
use App\Contracts\PhotoCreate\PhotoPipe;
use App\Events\PhotoSaved;

/**
* Persist current Photo object into database.
Expand All @@ -22,9 +21,6 @@ public function handle(PhotoDTO $state, \Closure $next): PhotoDTO
$state->getPhoto()->save();
$state->getPhoto()->tags()->sync($state->getTags()->pluck('id')->all());

// Dispatch event for album stats recomputation
PhotoSaved::dispatch($state->getPhoto()->id);

return $next($state);
}
}
5 changes: 5 additions & 0 deletions app/Actions/Photo/Pipes/Shared/SetParent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use App\Contracts\PhotoCreate\SharedPipe;
use App\DTO\PhotoCreate\DuplicateDTO;
use App\DTO\PhotoCreate\StandaloneDTO;
use App\Events\PhotoSaved;
use App\Exceptions\Internal\LycheeLogicException;
use App\Models\Album;
use Illuminate\Support\Facades\DB;
Expand Down Expand Up @@ -46,6 +47,10 @@ public function handle(DuplicateDTO|StandaloneDTO $state, \Closure $next): Dupli
$state->photo->load('albums');
}

// Dispatch event for album stats recomputation
// This must be done after SetParent so the photo_album relationship exists
PhotoSaved::dispatch($state->photo->id);

return $next($state);
}
}
31 changes: 31 additions & 0 deletions tests/ImageProcessing/Photo/PhotoAddTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@

namespace Tests\ImageProcessing\Photo;

use App\Jobs\RecomputeAlbumSizeJob;
use App\Jobs\RecomputeAlbumStatsJob;
use Illuminate\Support\Facades\Queue;
use Tests\Constants\TestConstants;
use Tests\Feature_v2\Base\BaseApiWithDataTest;

Expand Down Expand Up @@ -159,4 +162,32 @@ public function testGoogleMotionPicture(): void
$response = $this->deleteJson('Photo', ['photo_ids' => [$id], 'from_id' => 'unsorted']);
$this->assertNoContent($response);
}

public function testPhotoUploadDispatchesJobs(): void
{
// Fake only the recompute jobs, not the ProcessImageJob
// This allows the photo upload to complete while capturing the recompute job dispatches
Queue::fake([
RecomputeAlbumStatsJob::class,
RecomputeAlbumSizeJob::class,
]);

$this->catchFailureSilence = [];

// Upload a photo to an album
$response = $this->actingAs($this->admin)->upload('Photo', filename: TestConstants::SAMPLE_FILE_NIGHT_IMAGE, album_id: $this->album1->id);
$this->assertCreated($response);

// Assert that RecomputeAlbumStatsJob was dispatched for the album
Queue::assertPushed(RecomputeAlbumStatsJob::class, function (RecomputeAlbumStatsJob $job) {
return $job->album_id === $this->album1->id;
});

// Assert that RecomputeAlbumSizeJob was dispatched for the album
Queue::assertPushed(RecomputeAlbumSizeJob::class, function (RecomputeAlbumSizeJob $job) {
return $job->album_id === $this->album1->id;
});

$this->catchFailureSilence = ["App\Exceptions\MediaFileOperationException"];
}
}
Loading