Skip to content

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Jan 5, 2026

Summary by CodeRabbit

  • Chores
    • Added an automated daily cleanup for container package versions to reduce storage and keep recent releases accessible—untagged old versions are removed while a minimum number of recent versions are retained.

✏️ Tip: You can customize this high-level summary in your review settings.

@ildyria ildyria requested a review from a team as a code owner January 5, 2026 12:41
@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

A new GitHub Actions workflow was added to automatically delete old container package versions for the lychee package. It runs daily at 05:00 UTC and on pushes to master, deleting only untagged versions while keeping at least 10 recent versions.

Changes

Cohort / File(s) Changes
GitHub Actions workflow
.github/workflows/cleanup-old-packages.yml
Added workflow "Clean up old packages": triggers on cron 00 05 * * * (daily) and on pushes to master; job clean-up-old-packages uses actions/delete-package-versions@e5bc658... to remove untagged container package versions for package-name lychee, preserving a minimum of 10 versions and requiring contents: read, packages: write permissions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 I hop through tags and dusty stems,

I tidy packages, cheery gems.
Ten I keep, the rest take flight—
A clean repo by morning light.

Pre-merge checks

✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/cleanup-old-packages.yml (1)

11-12: Consider if the push trigger is necessary.

The workflow triggers both on a daily schedule and on every push to master. Since package cleanup is typically only needed periodically, the scheduled run should be sufficient. Running cleanup on every push to master may result in unnecessary workflow executions, especially if there are frequent pushes.

If immediate cleanup after pushes isn't required, consider removing this trigger.

🔎 Suggested change
-  push:
-    branches: [ "master" ]
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9b231e and 410da7d.

📒 Files selected for processing (1)
  • .github/workflows/cleanup-old-packages.yml
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
  • GitHub Check: 2️⃣ PHP dist / 8.4 - postgresql
  • GitHub Check: 1️⃣ PHP tests / 8.5 - sqlite -- Webshop
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Unit
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Webshop
  • GitHub Check: 1️⃣ PHP tests / 8.5 - sqlite -- Unit
  • GitHub Check: 1️⃣ PHP tests / 8.5 - sqlite -- ImageProcessing
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- Unit
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- Feature_v2
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Precomputing
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- ImageProcessing
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- ImageProcessing
  • GitHub Check: 1️⃣ PHP tests / 8.4 - mariadb -- Install
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Install
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Feature_v2
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- Precomputing
  • GitHub Check: 1️⃣ PHP 8.4 - PHPStan
🔇 Additional comments (2)
.github/workflows/cleanup-old-packages.yml (2)

1-3: LGTM!

Standard disclaimer for third-party actions is appropriate.


21-26: The workflow's use of actions/delete-package-versions@e5bc658cc4c965c472efe991f8beea3981499c55 pinned to v5.0.0 is appropriate. v5.0.0 is the latest published version, and no security advisories have been identified. The configuration parameters—keeping at least 10 versions and only deleting untagged versions—provide a safe cleanup strategy.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (a9b231e) to head (f5bf22c).
⚠️ Report is 2 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/cleanup-old-packages.yml (1)

9-10: Reconsider the push trigger on master.

Running cleanup on every push to master may be unnecessary and could potentially race with package creation workflows. Since the daily cron job handles regular cleanup, consider whether the push trigger adds value or just creates extra workflow runs.

🔎 Suggested fix to remove the push trigger
   schedule:
     - cron: '00 05 * * *'
-  push:
-    branches: [ "master" ]
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 410da7d and f5bf22c.

📒 Files selected for processing (1)
  • .github/workflows/cleanup-old-packages.yml
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: 3️⃣ Legacy Dockerfile Lint
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- Precomputing
  • GitHub Check: 1️⃣ PHP tests / 8.4 - sqlite -- Install
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- ImageProcessing
  • GitHub Check: 1️⃣ PHP tests / 8.5 - sqlite -- Feature_v2
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- Webshop
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Webshop
  • GitHub Check: 1️⃣ PHP tests / 8.5 - sqlite -- ImageProcessing
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Feature_v2
  • GitHub Check: 1️⃣ PHP tests / 8.5 - sqlite -- Precomputing
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- ImageProcessing
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- Install
  • GitHub Check: 1️⃣ PHP tests / 8.5 - mariadb -- Feature_v2
  • GitHub Check: 1️⃣ PHP tests / 8.5 - postgresql -- Unit
🔇 Additional comments (2)
.github/workflows/cleanup-old-packages.yml (2)

1-3: LGTM!

Standard disclaimer for third-party actions is appropriate.


12-17: LGTM!

Job definition and permissions are correctly configured for package cleanup operations.

@ildyria ildyria merged commit 2cb2515 into master Jan 5, 2026
44 checks passed
@ildyria ildyria deleted the clean-up-package-list branch January 5, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants