Skip to content

Add safety check to avoid breaking everything if the db query fails. #3939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ildyria merged 2 commits into from
Jan 5, 2026
Merged

Add safety check to avoid breaking everything if the db query fails. #3939

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4730135
add safety check to avoid breaking everything if the db query fails. …
ildyria Jan 5, 2026
4feec42
Add more logging options for jobs to not pollute the normal logs with…
ildyria Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/Http/Controllers/Admin/Maintenance/FullTree.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use App\Http\Resources\Diagnostics\AlbumTree;
use Illuminate\Routing\Controller;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\DB;

/**
* Maybe the album tree is broken.
Expand All @@ -28,9 +29,12 @@ class FullTree extends Controller
*/
public function do(FullTreeUpdateRequest $request): void
{
$key_name = 'id';
$album_instance = new Album();
batch()->update($album_instance, $request->albums(), $key_name);
// Wrap this in a transaction to ensure atomicity
DB::transaction(function () use ($request): void {
$key_name = 'id';
$album_instance = new Album();
batch()->update($album_instance, $request->albums(), $key_name);
});

AlbumRouteCacheUpdated::dispatch();
}
Expand Down
Loading