Skip to content

Update Show method to marshal to UI thread #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ionite34 merged 6 commits into from
Apr 19, 2026
+36 −33
Merged

Update Show method to marshal to UI thread #1613

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d03a65b
Update Show method to marshal to UI thread
NeuralFault Apr 18, 2026
9c1b00b
Simplify thread marshal
NeuralFault Apr 18, 2026
88a7408
remove stray orphaned block
NeuralFault Apr 18, 2026
5870417
Update PreviewImageUri to point to the new canvas image location
NeuralFault Apr 18, 2026
e52543b
Update PreviewImageUri to original image that was moved to doc-old di…
NeuralFault Apr 18, 2026
840d808
Update CHANGELOG for v2.15.8 fixes
ionite34 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 29 additions & 32 deletions StabilityMatrix.Avalonia/Services/NotificationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,14 @@ public void Initialize(
notificationManager = new WindowNotificationManager(TopLevel.GetTopLevel(visual))
{
Position = position,
MaxItems = maxItems
MaxItems = maxItems,
};
}

public void Show(INotification notification)
{
notificationManager?.Show(notification);
// Must marshal to UI thread - WindowNotificationManager requires it
Dispatcher.UIThread.Invoke(() => notificationManager?.Show(notification));
}

/// <inheritdoc />
Expand Down Expand Up @@ -94,25 +95,23 @@ bool isPersistent
// Show app toast
if (isPersistent)
{
Dispatcher.UIThread.Invoke(
() =>
ShowPersistent(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType()
)
Dispatcher.UIThread.Invoke(() =>
ShowPersistent(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType()
)
);
}
else
{
Dispatcher.UIThread.Invoke(
() =>
Show(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType(),
expiration
)
Dispatcher.UIThread.Invoke(() =>
Show(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType(),
expiration
)
);
}
return;
Expand All @@ -130,25 +129,23 @@ await nativeManager.ShowNotification(
// Show app toast
if (isPersistent)
{
Dispatcher.UIThread.Invoke(
() =>
ShowPersistent(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType()
)
Dispatcher.UIThread.Invoke(() =>
ShowPersistent(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType()
)
);
}
else
{
Dispatcher.UIThread.Invoke(
() =>
Show(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType(),
expiration
)
Dispatcher.UIThread.Invoke(() =>
Show(
notification.Title ?? "",
notification.Body ?? "",
key.Level.ToNotificationType(),
expiration
)
);
}

Expand Down
4 changes: 3 additions & 1 deletion StabilityMatrix.Core/Models/Packages/InvokeAI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ IPipWheelService pipWheelService
public override PackageDifficulty InstallerSortOrder => PackageDifficulty.Advanced;

public override Uri PreviewImageUri =>
new("https://raw.githubusercontent.com/invoke-ai/InvokeAI/main/docs/assets/canvas_preview.png");
new(
"https://raw.githubusercontent.com/invoke-ai/InvokeAI/refs/heads/main/docs-old/assets/canvas_preview.png"
);

public override IEnumerable<SharedFolderMethod> AvailableSharedFolderMethods =>
[SharedFolderMethod.None, SharedFolderMethod.Configuration];
Expand Down
Loading