Pin executable Hugging Face model downloads to revisions #1688
+49
−4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| using System.Reflection; | ||
| using StabilityMatrix.Core.Helper; | ||
| using StabilityMatrix.Core.Models; | ||
|
|
||
| namespace StabilityMatrix.Tests.Core; | ||
|
|
||
| public class RemoteModelsTests | ||
| { | ||
| [Fact] | ||
|
Check failure on line 9 in StabilityMatrix.Tests/Core/RemoteModelsTests.cs
|
||
| public void ExecutableHuggingFaceModelsUsePinnedRevisions() | ||
| { | ||
| var executableExtensions = new HashSet<string>(StringComparer.OrdinalIgnoreCase) | ||
| { | ||
| ".bin", | ||
| ".ckpt", | ||
| ".pt", | ||
| ".pth", | ||
| }; | ||
|
|
||
| var resources = typeof(RemoteModels) | ||
| .GetProperties(BindingFlags.Public | BindingFlags.Static) | ||
| .Select(property => property.GetValue(null)) | ||
| .SelectMany( | ||
| value => | ||
| value switch | ||
| { | ||
| IEnumerable<RemoteResource> remoteResources => remoteResources, | ||
| IEnumerable<HybridModelFile> hybridModels => hybridModels | ||
| .Where(model => model.DownloadableResource.HasValue) | ||
| .Select(model => model.DownloadableResource!.Value), | ||
| HybridModelFile { DownloadableResource: { } resource } => [resource], | ||
| _ => [], | ||
| } | ||
| ); | ||
|
|
||
| var unpinnedModels = resources | ||
| .Where(resource => resource.Url.Host == "huggingface.co") | ||
| .Where(resource => executableExtensions.Contains(Path.GetExtension(resource.Url.AbsolutePath))) | ||
| .Where(resource => resource.Url.AbsolutePath.Contains("/resolve/main/", StringComparison.Ordinal)) | ||
| .Select(resource => resource.Url) | ||
| .ToArray(); | ||
|
|
||
| Assert.Empty(unpinnedModels); | ||
| } | ||
|
Comment on lines
+2
to
+44
Contributor
There was a problem hiding this comment. The current regression test only validates using System.Reflection;
using StabilityMatrix.Core.Helper;
using StabilityMatrix.Core.Models;
namespace StabilityMatrix.Tests.Core;
public class RemoteModelsTests
{
[Fact]
public void ExecutableHuggingFaceModelsUsePinnedRevisions()
{
var executableExtensions = new HashSet<string>(StringComparer.OrdinalIgnoreCase)
{
".bin",
".ckpt",
".pt",
".pth",
};
var properties = typeof(RemoteModels).GetProperties(BindingFlags.Public | BindingFlags.Static);
var resources = new List<RemoteResource>();
foreach (var prop in properties)
{
var value = prop.GetValue(null);
if (value is IEnumerable<RemoteResource> remoteResources)
{
resources.AddRange(remoteResources);
}
else if (value is IEnumerable<HybridModelFile> hybridModels)
{
resources.AddRange(hybridModels
.Where(m => m.DownloadableResource.HasValue)
.Select(m => m.DownloadableResource!.Value));
}
else if (value is HybridModelFile singleHybrid && singleHybrid.DownloadableResource.HasValue)
{
resources.Add(singleHybrid.DownloadableResource.Value);
}
}
var unpinnedModels = resources
.Where(resource => resource.Url.Host == "huggingface.co")
.Where(resource => executableExtensions.Contains(Path.GetExtension(resource.Url.AbsolutePath)))
.Where(resource => resource.Url.AbsolutePath.Contains("/resolve/main/", StringComparison.Ordinal))
.Select(resource => resource.Url)
.ToArray();
Assert.Empty(unpinnedModels);
}
Author
There was a problem hiding this comment. I have read the CLA Document and I hereby sign the CLA |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm not sure this PR needs tests exactly, but you will need to change to MSTest format, we're not using xunit and this isn't building right now.