Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixed in website_qa module - error in resolving urls #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sabhashanki
Copy link

Description

In the website_qa module, extracted href tags are concatenated with the input URL, throwing an error in resolving it

What: Removed the code for concatenation and added URL validator
Why: To avoid errors in resolving URLs
How: Added validator package to verify the URL pattern

What type of PR is this?

  • 🎁 New feature (non-breaking change which adds functionality)
  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • πŸ’£ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“ Documentation update
  • 🎨 Refactor or style update
  • πŸ”₯ Performance improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI, review, release, devops, chore, etc.

Added tests?

  • β˜‘οΈ Yes
  • ❎ No, and this is why:
  • ❓ No, because I need help.

How can this be tested?

Test A

  • Description: No changes
  • Test Configuration: No change in configuration
  • Test Instructions: No change in instruction
  • Libraries: No changes
  • Expected Result: Display the answer for the input query

[optional] Are there any post-deployment tasks we need to perform?

Checklist:

  • 😎 My code follows the style guidelines of this project.
  • β˜‘οΈ I have performed a self-review of my code.
  • πŸ“‘ I have commented my code, particularly in hard-to-understand areas.
  • πŸ”– I have made corresponding changes to the documentation.
  • ⚠️ My changes generate no new warnings.
  • 🧐 I have added tests that prove my fix is effective or that my feature works.
  • βœ… New and existing unit tests pass locally with my changes.
  • πŸ”— Any dependent changes have been merged and published in downstream modules.

Required links:

  • Linear Issue:
  • Testing Notebook (Colab):
  • Code Documentation (Confluence):
  • User Documentation (Confluence):

Contributors:

  • Shankesh Raju MS

@sabhashanki sabhashanki changed the base branch from experimental to main February 8, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants