Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the possibility to close the client #1

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add the possibility to close the client #1

merged 1 commit into from
Apr 23, 2024

Conversation

dodomorandi
Copy link
Collaborator

This should be a simple and effective way to (sort of) gracefully close the client.

@dodomorandi dodomorandi self-assigned this Apr 22, 2024
@dodomorandi dodomorandi force-pushed the stop-client branch 2 times, most recently from e1d23c1 to c08a591 Compare April 23, 2024 15:07
@paolobarbolini
Copy link
Member

clippy doesn't seem happy.

@dodomorandi
Copy link
Collaborator Author

Yup, forgot that too_many_arguments is not a pedantic lint, I made some last checks enabling pedantic lints and I just did not consider that one. Pushing again in a few minutes.

@dodomorandi dodomorandi merged commit 4ea7a9f into main Apr 23, 2024
12 checks passed
@dodomorandi dodomorandi deleted the stop-client branch April 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolobarbolini paolobarbolini paolobarbolini approved these changes

Assignees

@dodomorandi dodomorandi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dodomorandi @paolobarbolini