Skip to content

fix: 회원가입 페이지, 홈 컨테이너 영역 수정 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heesunee merged 3 commits into from
Sep 8, 2025
Merged

fix: 회원가입 페이지, 홈 컨테이너 영역 수정 #389

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50ba2ce
fix: 이용가이드 기본 컨테이 너 영역 설정 (#388)
Sep 8, 2025
47ecd86
fix: signup page 불필요한 div 삭제 (#388)
Sep 8, 2025
0eefe2d
fix: 오타 수정 (#388)
Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/components/top-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const TopSection = () => {
};

return (
<section className="bg-gray-black px-[1.6rem] pt-[0.1rem]">
<section className="min-h-[9.6rem] bg-gray-black px-[1.6rem] pt-[0.1rem]">
<CardBanner
subText="나와 딱 맞는 직관 메이트를 찾고 싶다면?"
text="이용가이드 보러 가기"
Expand Down
4 changes: 2 additions & 2 deletions src/pages/sign-up/components/signup-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ const SignupStep = () => {
return (
<form
onSubmit={handleSubmit(onSubmit)}
className="h-svh w-full flex-col justify-between gap-[4rem] px-[1.6rem] pt-[4rem] pb-[1.6rem]"
className="h-full w-full flex-col justify-between gap-[4rem] px-[1.6rem] pt-[4rem] pb-[1.6rem]"
>
<div className="w-full flex-col gap-[4rem]">
<div className="h-full w-full flex-col gap-[4rem]">
<h1 className="title_24_sb whitespace-pre-line">{NICKNAME_TITLE}</h1>
<div className=" flex-col gap-[2.4rem]">
<div className="flex-col gap-[0.8rem]">
Expand Down
20 changes: 9 additions & 11 deletions src/pages/sign-up/sign-up.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,15 @@ const SignUp = () => {
const { Funnel, Step, goNext } = useFunnel(SIGNUP_STEPS, ROUTES.HOME);

return (
<div className="h-full flex-col bg-gray-white">
<div className="flex-1">
<Funnel>
<Step name="AGREEMENT">
<AgreementStep next={goNext} />
</Step>
<Step name="INFORMATION">
<SignupStep />
</Step>
</Funnel>
</div>
<div className="h-fullflex-col bg-gray-white">
Copy link

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

클래스명 오타: h-fullflex-col → 공백 누락으로 클래스 인식 실패. 또한 flex 미지정.

공백 누락으로 두 유틸이 모두 무효화됩니다. 또 flex-col이 의미를 가지려면 flex가 필요합니다.

권장 패치:

-    <div className="h-fullflex-col bg-gray-white">
+    <div className="h-full flex flex-col bg-gray-white">
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div className="h-fullflex-col bg-gray-white">
<div className="h-full flex flex-col bg-gray-white">
🤖 Prompt for AI Agents 
In src/pages/sign-up/sign-up.tsx around line 11 the div has a typo in className:
"h-fullflex-col bg-gray-white" — insert a space between h-full and flex-col and
add the missing flex utility so the classes read "h-full flex flex-col
bg-gray-white" to ensure height, flex container and column direction are
applied.

<Funnel>
<Step name="AGREEMENT">
<AgreementStep next={goNext} />
</Step>
<Step name="INFORMATION">
<SignupStep />
</Step>
</Funnel>
</div>
);
};
Expand Down