Skip to content

Conversation

@junjeeong
Copy link
Collaborator

Pull requests

✅ 작업한 내용

  • [o] 이슈에 적어둔것과 동일합니다.

🔢 #173

❗️PR Point

  • 이용약관과 개인정보처리방침에 ui가 똑같아 하나의 Modal 컴포넌트로 추상화했습니다.
  • Modal을 어떻게 렌더링 할지에 대한 책임은 부모 컴포넌트에게 있고 Modal에게는 이용약관인지, 개인정보인지 정하는 mode와 X 버튼을 눌렀을 때 모달이 닫히는 closeModal 함수만 prop으로 전달해주면 됩니다.
  • isModalOpen 값이 객체입니다. 속성으로는 isOpen, mode가 있습니다.

📸 스크린샷

@junjeeong junjeeong added the 👩‍💻 Feat 새로운 기능 label Apr 10, 2025
@junjeeong junjeeong requested a review from Soohyuniii April 10, 2025 05:52
@junjeeong junjeeong self-assigned this Apr 10, 2025
@junjeeong junjeeong linked an issue Apr 10, 2025 that may be closed by this pull request
2 tasks
@@ -0,0 +1,25 @@
export const TERMS = `제 1조 (목적)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junjeeong 파일명 오타있는 것 같아요!

@@ -1,31 +1,41 @@
import { PRIVACY } from "@/constants/PRIVACY";
import { TERMS } from "@/constants/TEMRS";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junjeeong 파일명 수정하면 같이 반영해주세요!

Copy link
Collaborator Author

@junjeeong junjeeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TERMS 오타 수정했습니다!

@junjeeong junjeeong requested a review from Soohyuniii April 10, 2025 07:04
@junjeeong junjeeong merged commit 8f1a391 into dev Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👩‍💻 Feat 새로운 기능

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: 이용약관, 개인정보처리방침 모달

3 participants