Skip to content

fix: 친구 저장하기 버튼 문구, navigate 수정 및 ga element 변경 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soohyuniii merged 2 commits into from
Apr 29, 2025
Merged

fix: 친구 저장하기 버튼 문구, navigate 수정 및 ga element 변경 #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecd3c2d
fix: 친구 저장하기 버튼 문구와 navigate 수정 및 ga element 변경
Soohyuniii Apr 29, 2025
c849e78
Merge branch 'dev' of https://github.com/MBTips/FE-MBTips into fix/친구…
Soohyuniii Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/pages/SelectInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ const SelectInfo = () => {
? testResultMBTI
: undefined;

const confirmButtonText =
type === "fastFriend" ? "대화 시작하기" : "친구 저장하기";

const [selectedMBTI, setSelectedMBTI] = useState<{
[key: string]: string | null;
}>({
Expand Down Expand Up @@ -152,7 +155,7 @@ const SelectInfo = () => {
setTimeout(() => setToastMessage(null), 3000);
};

const handleStartChat = async () => {
const handleConfirmButton = async () => {
const isMBTIComplete = Object.values(selectedMBTI).every(
(val) => val !== null
);
Expand Down Expand Up @@ -201,16 +204,9 @@ const SelectInfo = () => {
if (type === "virtualFriend" && isVirtualFriendResponse(responseData)) {
trackEvent("Click", {
page: "친구 저장",
element: "대화 시작하기"
});
navigate("/chat", {
state: {
mbti,
mode: type,
id: responseData.conversationId,
name: responseData.virtualFriendName
}
element: "친구 저장하기"
});
navigate("/");
} else if (type === "fastFriend" && typeof responseData === "number") {
trackEvent("Click", {
page: "빠른 대화 설정",
Expand Down Expand Up @@ -372,9 +368,9 @@ const SelectInfo = () => {
{/* 대화 시작 버튼 */}
<button
className="my-[22px] h-[60px] w-full rounded-[8px] bg-primary-normal font-bold text-white"
onClick={handleStartChat}
onClick={handleConfirmButton}
>
대화 시작하기
{confirmButtonText}
</button>
</div>
</div>
Expand Down