Ajout du scrollView à la page DéfaultNotification #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaudeArs
commented
Sep 23, 2024
•
ClaudeArs
commented
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
fc-santos
reviewed
Sep 23, 2024
| <ScrollView style={styles.container}> | ||
| <View style={styles.section}> | ||
| <HeaderText title={t('DefaultNotificationPage.Title')} /> | ||
| <Text style={styles.sectionDescriptionTitle}> {t('DefaultNotificationPage.Description')}</Text> |
There was a problem hiding this comment.
J'avais fait un test pour le scrollView, portant dans mon code je les ai enlevé
fc-santos
reviewed
Sep 23, 2024
| <Text style={styles.sectionDescription}> {t('DefaultNotificationPage.ANIGAcceptDescription')}</Text> | ||
| </View> | ||
| <View style={styles.button}> | ||
| <Button |
There was a problem hiding this comment.
Il faut ajouter un bouton secondaire pour revenir à la page d'accueil. Je crois que les boutons serait placés en dehors de la ScrollView pour qu'on les affichent en tout temps sans avoir à faire défiler la page.
Signed-off-by: Claude Arseneault <[email protected]>
fc-santos
reviewed
Sep 24, 2024
| pageContainer: { | ||
| flex: 1, | ||
| container: { | ||
| height: '77%', |
There was a problem hiding this comment.
j'aurais peut-être mis flex: 3 pour ce container et dans le styles.button flex: 1. Comme ça container prend 3/4 et button 1/4.
fc-santos
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.