Skip to content

viewport -> containerDimensions #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chelojimenez merged 1 commit into from
Jan 13, 2026
Merged

viewport -> containerDimensions #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 14 additions & 28 deletions mcpjam-inspector/client/src/components/chat-v2/thread/mcp-apps-renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export function MCPAppsRenderer({
[isPlaygroundActive, playgroundSafeAreaInsets],
);

// Get device type and custom viewport from playground store for platform/viewport derivation (SEP-1865)
// Get device type and custom viewport from playground store for platform/containerDimensions derivation (SEP-1865)
const playgroundDeviceType = useUIPlaygroundStore((s) => s.deviceType);
const customViewport = useUIPlaygroundStore((s) => s.customViewport);

Expand All @@ -235,23 +235,6 @@ export function MCPAppsRenderer({
}
}, [isPlaygroundActive, playgroundDeviceType]);

// Derive viewport dimensions from device type (using shared config + custom viewport)
const viewportWidth = useMemo(() => {
if (!isPlaygroundActive) return 400;
if (playgroundDeviceType === "custom") {
return customViewport.width;
}
return DEVICE_VIEWPORT_CONFIGS[playgroundDeviceType].width;
}, [isPlaygroundActive, playgroundDeviceType, customViewport]);

const viewportHeight = useMemo(() => {
if (!isPlaygroundActive) return 400;
if (playgroundDeviceType === "custom") {
return customViewport.height;
}
return DEVICE_VIEWPORT_CONFIGS[playgroundDeviceType].height;
}, [isPlaygroundActive, playgroundDeviceType, customViewport]);

// Display mode: controlled (via props) or uncontrolled (internal state)
const isControlled = displayModeProp !== undefined;
const [internalDisplayMode, setInternalDisplayMode] = useState<DisplayMode>(
Expand Down Expand Up @@ -290,7 +273,7 @@ export function MCPAppsRenderer({
],
);

// maxHeight is sent to guest UI as part of viewport info (SEP-1865 protocol)
// maxHeight is sent to guest UI as part of containerDimensions (SEP-1865 protocol)
// Note: We no longer use this to clamp resize, but apps may use it for layout decisions
const maxHeight = useMemo(() => {
if (!isPlaygroundActive) return 800;
Expand Down Expand Up @@ -330,7 +313,8 @@ export function MCPAppsRenderer({
const onRequestPipRef = useRef(onRequestPip);
const onExitPipRef = useRef(onExitPip);
const setDisplayModeRef = useRef(setDisplayMode);
const viewportWidthRef = useRef(viewportWidth);
const isPlaygroundActiveRef = useRef(isPlaygroundActive);
const playgroundDeviceTypeRef = useRef(playgroundDeviceType);
const effectiveDisplayModeRef = useRef(effectiveDisplayMode);
const serverIdRef = useRef(serverId);
const toolCallIdRef = useRef(toolCallId);
Expand Down Expand Up @@ -542,9 +526,7 @@ export function MCPAppsRenderer({
theme: themeMode,
displayMode: effectiveDisplayMode,
availableDisplayModes: ["inline", "pip", "fullscreen"],
viewport: {
width: viewportWidth,
height: viewportHeight,
containerDimensions: {
maxHeight,
maxWidth,
},
Expand Down Expand Up @@ -574,8 +556,6 @@ export function MCPAppsRenderer({
[
themeMode,
effectiveDisplayMode,
viewportWidth,
viewportHeight,
maxHeight,
maxWidth,
locale,
Expand All @@ -600,7 +580,8 @@ export function MCPAppsRenderer({
onRequestPipRef.current = onRequestPip;
onExitPipRef.current = onExitPip;
setDisplayModeRef.current = setDisplayMode;
viewportWidthRef.current = viewportWidth;
isPlaygroundActiveRef.current = isPlaygroundActive;
playgroundDeviceTypeRef.current = playgroundDeviceType;
effectiveDisplayModeRef.current = effectiveDisplayMode;
serverIdRef.current = serverId;
toolCallIdRef.current = toolCallId;
Expand All @@ -611,7 +592,8 @@ export function MCPAppsRenderer({
onRequestPip,
onExitPip,
setDisplayMode,
viewportWidth,
isPlaygroundActive,
playgroundDeviceType,
effectiveDisplayMode,
serverId,
toolCallId,
Expand Down Expand Up @@ -770,7 +752,11 @@ export function MCPAppsRenderer({

bridge.onrequestdisplaymode = async ({ mode }) => {
const requestedMode = mode ?? "inline";
const isMobile = viewportWidthRef.current < 768;
// Use device type for mobile detection (defaults to mobile-like behavior when not in playground)
const isMobile = isPlaygroundActiveRef.current
? playgroundDeviceTypeRef.current === "mobile" ||
playgroundDeviceTypeRef.current === "tablet"
: true;
const actualMode: DisplayMode =
isMobile && requestedMode === "pip" ? "fullscreen" : requestedMode;

Expand Down