Improve mipper by weighting based on block type and luminance #66
+128
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks vanilla for removing skylight data from blocks below snow layers
|
on src/main/java/me/cortex/voxy/common/world/other/Mipper.java:108 if(blockState.isOf(Blocks.SNOW) && i >= 4 ) { // If snow and a top block, remove lighting from block belowI had to replace this with if(mapper.getBlockStateFromBlockId(blockId).isOf(Blocks.SNOW) && i >= 4 ) { // If snow and a top block, remove lighting from block belowin order to compile |
I may have forgotten to commit half the file
Oops! Fixed. |
|
Unrelated to this PR |
|
😭 you might've forgotten a semicolon on src/main/java/me/cortex/voxy/common/world/other/Mipper.java:97 |
I should probably make commits from an ide instead of the gh web ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes config creation error