Bring back performance (part 1)

bench/bench_user.py

@@ -50,9 +50,9 @@ def using_revoltpy():
     def using_voltage():
         return voltage.User(data=payload, cache=vpy_cache)
 
-    time_pyvolt = timeit.timeit(using_pyvolt,     number=1_000_000)
-    time_revoltpy = timeit.timeit(using_revoltpy, number=1_000_000)
-    time_voltage = timeit.timeit(using_voltage,   number=1_000_000)
+    time_pyvolt = timeit.timeit(using_pyvolt,     number=100_000)
+    time_revoltpy = timeit.timeit(using_revoltpy, number=100_000)
+    time_voltage = timeit.timeit(using_voltage,   number=100_000)
 
     print(f"[User] Time using pyvolt ----: {time_pyvolt:.6f} seconds")
     print(f"[User] Time using revolt.py -: {time_revoltpy:.6f} seconds")

pyvolt/parser.py

@@ -5,7 +5,7 @@
 import logging
 import typing as t
 
-from . import cdn, core, discovery
+from . import core, discovery
 from .auth import (
     PartialAccount,
     MFATicket,
@@ -19,6 +19,11 @@
     LoginResult,
 )
 from .bot import BotFlags, Bot, PublicBot
+from .cdn import (
+    AssetMetadataType,
+    AssetMetadata,
+    StatelessAsset,
+)
 from .channel import (
     PartialChannel,
     SavedMessagesChannel,
@@ -182,25 +187,22 @@ def __init__(self, state: State) -> None:
 
     # basic start
 
-    def parse_asset_metadata(self, d: raw.Metadata) -> cdn.AssetMetadata:
-        return cdn.AssetMetadata(
-            type=cdn.AssetMetadataType(d["type"]),
+    def parse_asset_metadata(self, d: raw.Metadata) -> AssetMetadata:
+        return AssetMetadata(
+            type=AssetMetadataType(d["type"]),
             width=d.get("width"),
             height=d.get("height"),
         )
 
-    def parse_asset(self, d: raw.File) -> cdn.StatelessAsset:
-        deleted = d.get("deleted")
-        reported = d.get("reported")
-
-        return cdn.StatelessAsset(
+    def parse_asset(self, d: raw.File) -> StatelessAsset:
+        return StatelessAsset(
             id=d["_id"],
             filename=d["filename"],
             metadata=self.parse_asset_metadata(d["metadata"]),
             content_type=d["content_type"],
             size=d["size"],
-            deleted=deleted or False,
-            reported=reported or False,
+            deleted=d.get("deleted", False),
+            reported=d.get("reported", False),
             message_id=d.get("message_id"),
             user_id=d.get("user_id"),
             server_id=d.get("server_id"),
@@ -1030,8 +1032,8 @@ def parse_mfa_response_login(
         return MFARequired(
             ticket=d["ticket"],
             allowed_methods=[MFAMethod(m) for m in d["allowed_methods"]],
-            internal_friendly_name=friendly_name,
             state=self.state,
+            internal_friendly_name=friendly_name,
         )
 
     def parse_mfa_ticket(self, d: raw.a.MFATicket) -> MFATicket:
@@ -1170,11 +1172,11 @@ def parse_response_webhook(self, d: raw.ResponseWebhook) -> Webhook:
             id=webhook_id,
             name=d["name"],
             internal_avatar=(
-                cdn.StatelessAsset(
+                StatelessAsset(
                     id=avatar,
                     filename="",
-                    metadata=cdn.AssetMetadata(
-                        type=cdn.AssetMetadataType.IMAGE,
+                    metadata=AssetMetadata(
+                        type=AssetMetadataType.IMAGE,
                         width=None,
                         height=None,
                     ),