-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest-timeout to CI #4215
Add pytest-timeout to CI #4215
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4215 +/- ##
========================================
Coverage 93.62% 93.62%
========================================
Files 193 193
Lines 25294 25295 +1
Branches 4063 4063
========================================
+ Hits 23682 23683 +1
Misses 1096 1096
Partials 516 516 ☔ View full report in Codecov by Sentry. |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and FWIW SciPy also has pytest-timeout
in some of our CI runs and pyproject.toml
optional deps. Looks like threshold is 60
s over there.
We should probably check this more closely as noted in the matching issue, but core devs seem in favor of this temporary solution over there in any case.
test_streamplot_2D
mentioned over there is probably for me to investigate, I wrote that with Matthieu.
The only failures I saw in this PR when CI last flushed were timeouts at > 100 s
, which is actually pretty wild for a single test!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Temporary patch for #4209
Changes made in this Pull Request:
PR Checklist
📚 Documentation preview 📚: https://mdanalysis--4215.org.readthedocs.build/en/4215/