Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallelization for analysis.polymer.PersistenceLength #4870

Closed
wants to merge 0 commits into from

Conversation

tanishy7777
Copy link
Contributor

@tanishy7777 tanishy7777 commented Dec 27, 2024

Fixes #4671

Changes made in this Pull Request:

  • Enabled parallelization for PersistenceLength class
  • added tests (including fixtures in analysis/conftest.py)
  • update CHANGELOG

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4870.org.readthedocs.build/en/4870/

@pep8speaks
Copy link

pep8speaks commented Dec 27, 2024

Hello @tanishy7777! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 309:80: E501 line too long (86 > 79 characters)

Line 172:1: E302 expected 2 blank lines, found 1
Line 174:25: W292 no newline at end of file

Line 174:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-12-28 08:08:44 UTC

@tanishy7777
Copy link
Contributor Author

tanishy7777 commented Dec 27, 2024

I enabled parallization the way it was mentioned in PR #4682 and have read through this.

But I am unable to fix this AssertionError.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDAnalysis.analysis.polymer: Implement parallelization or mark as unparallelizable
2 participants