Skip to content

Fix lifecycle ownership of Android edge overlays - #10

Merged
MDHaarith merged 1 commit into
mainfrom
fix/android-edge-panel-crash
Oct 23, 2026
Merged

MDHaarith merged 1 commit into
mainfrom
fix/android-edge-panel-crash

Conversation

@MDHaarith

Copy link
Copy Markdown
Owner

Summary

  • Fix lifecycle and saved state owner placement on Android edge overlay roots, preventing crashes when side sharing is enabled.
  • Guard edge handle construction so failures are logged without crashing the app.
  • Add a regression test for lifecycle ownership on the handle root.

Testing

  • Android unit tests: 36 passed, 1 skipped.
  • Debug and release builds succeeded.
  • Emulator: toggled side sharing, opened and closed the panel, and restarted without crashes.
  • Not run: real device validation and Linux transfer checks.

Attach lifecycle and saved-state owners to both overlay roots so Compose can create its window recomposer. Log handle construction failures instead of crashing the app, and cover root ownership with a regression test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T07:07:52.715185Z 3e374d4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@MDHaarith
MDHaarith merged commit 935cd78 into main Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant