Repository navigation
Android: a real drop card on the screen edge, Inter type, clearer overlay notice - #6
Merged
Merged
Conversation
…rlay notice - While something is dragged, the edge handle opens into a card drawn with the app's own components instead of canvas text: device avatars, "My device" / "Default" labels, "Send to all" only when there are several devices, and the row under the finger in blue with a light haptic tick. Your default device comes first. With no devices yet it is a small "Drop here / Release to send" tab. Row geometry is shared between the window size and the drop mapping (DropTabLayout) - The handle window is now a FrameLayout (pill + compose card); drag and receive-content listeners moved to it, behaviour unchanged - Inter (OFL, Latin subset, 4 weights, ~480 KB) for all text: closer to Apple's SF than Roboto - Settings explains Android's "displaying over other apps" notice while the edge handle is on, and how to hide it - Screenshots: drop card (right, hovering), left side, no devices; version 0.1.2 (code 3) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0165y3zUpEngKKwYegoWXTLK
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
UI polish on top of 06b7591 (device-targeted drops):
Changes
Drop card. While something is dragged, the handle now opens into a Compose card (
ui/DropTab.kt):DropTabLayout, so they can't drift apart.FrameLayoutholding the pill and the Compose card. The drag and receive-content listeners moved to it unchanged: targets, busy checks, permission grants andonDropbehave exactly as in 06b7591.Typography. All text now uses Inter (SIL OFL, Latin subset, 4 weights, about 480 KB). Other scripts fall back to the system font. The license is in
android/third_party/inter/OFL.txtand credited in the README.Overlay notice. Settings now explains, under Sending, why Android shows that notice and how to hide it: long-press it, and the handle keeps working. Android posts the notice for every app that draws over others, so the app can't remove it.
The version is now 0.1.2 (code 3).
Testing
testDebugUnitTest(35 tests, including the Linux interop test),verifyPaparazziDebugwith re-recorded screenshots, andassembleReleaseall pass locally.Generated by Claude Code